About/Committees Page #56

Merged
saltyypanda merged 28 commits from dev/committees into main 2023-10-14 19:06:47 +00:00
saltyypanda commented 2023-10-14 18:43:00 +00:00 (Migrated from github.com)

This is the about/committees page. It contains content briefly describing each committee (not primary officers) alongside an image for each (currently a placeholder image).

https://github.com/rit-sse/WebsiteTheSSEquel/assets/111908488/cb376dc2-e392-45a9-9933-329f1a1c60a8

This is the about/committees page. It contains content briefly describing each committee (not primary officers) alongside an image for each (currently a placeholder image). https://github.com/rit-sse/WebsiteTheSSEquel/assets/111908488/cb376dc2-e392-45a9-9933-329f1a1c60a8
2nPlusOne (Migrated from github.com) requested changes 2023-10-14 19:01:49 +00:00
@ -0,0 +1,140 @@
import Image from 'next/image'
2nPlusOne (Migrated from github.com) commented 2023-10-14 18:50:36 +00:00

Let's rename this to something like imageSide.

As you pointed out already, there also needs to be an 'imageSrc' property so we can pass in the image itself.

Let's rename this to something like imageSide. As you pointed out already, there also needs to be an 'imageSrc' property so we can pass in the image itself.
2nPlusOne (Migrated from github.com) commented 2023-10-14 18:56:05 +00:00

In general, let's try to extract components to their own files. For now, they can just exist within the folder for the route (the committees folder in this case. Then later we can move shared components into a different folder).

In general, let's try to extract components to their own files. For now, they can just exist within the folder for the route (the committees folder in this case. Then later we can move shared components into a different folder).
2nPlusOne (Migrated from github.com) approved these changes 2023-10-14 19:05:33 +00:00
2nPlusOne (Migrated from github.com) left a comment

Great job!

Great job!
raynardmiot (Migrated from github.com) approved these changes 2023-10-14 19:06:24 +00:00
raynardmiot (Migrated from github.com) left a comment

LGTM

LGTM
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SSE/WebsiteTheSSEquel!56
No description provided.