Refactored some of the GoLinksContainer, fixed issue #139 #249

Merged

Nogardagem merged 1 commit from golink-container-fixes into main

2025-11-18 16:13:04 +00:00

Nogardagem commented

2025-11-04 18:38:32 +00:00

(Migrated from github.com)

I changed the GoLinksContainer file to use ternary operators within the return instead of conditionally returning two nearly identical objects with only the inclusion of the GoLinkData changes.

Then, I added a condition to display the "Loading..." message only when the GoLinkData list contains a link with id -1, and I set the default value of the GoLinkData to a single element with id -1. Once the fetch for GoLinks is finished, it would be replaced with valid GoLinks (id != -1) or an empty list, which is checked to display "No GoLinks available".

I changed the GoLinksContainer file to use ternary operators within the return instead of conditionally returning two nearly identical objects with only the inclusion of the GoLinkData changes. Then, I added a condition to display the "Loading..." message only when the GoLinkData list contains a link with id -1, and I set the default value of the GoLinkData to a single element with id -1. Once the fetch for GoLinks is finished, it would be replaced with valid GoLinks (id != -1) or an empty list, which is checked to display "No GoLinks available".

pybash commented

2025-11-18 16:12:57 +00:00

(Migrated from github.com)

Sweet. LGTM! 🚀